This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
How to keep Reviewed-by lines in git commits with gerrit.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: libc-alpha <libc-alpha at sourceware dot org>, Florian Weimer <fweimer at redhat dot com>
- Date: Tue, 12 Nov 2019 12:35:36 -0500
- Subject: How to keep Reviewed-by lines in git commits with gerrit.
Florian,
If we ever switch to supporting Gerrit, then we will automatically
gain the Reviewed-by: lines depending on the configuration of Gerrit.
Reviewers would understand this as part of doing their reviews and
granting the review +1/+2.
In the meantime I can do two things as a reviewer to help you keep
the Reviewed-by lines.
1. If I am about to grant +2 review I edit the commit and generate
a new patchset version, and add my Reviewed-by line.
2. I submit my review of +2.
Then when you push, you just need to make sure your new commit message
matches and it should close the review.
--
Cheers,
Carlos.