This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] nptl: Fix niggles with pthread_clockjoin_np
On 04/11/2019 15:13, Joseph Myers wrote:
> On Sat, 2 Nov 2019, Rafal Luzynski wrote:
>
>> 2.11.2019 11:52 Mike Crowe <mac@mcrowe.com> wrote:
>>>
>>> Joseph Myers spotted[1] that 69ca4b54c151cec42ccca5e05790efc1a8206b47
>>> added
>>> pthread_clockjoin_np to sysdeps/nptl/pthread.h but not to its
>>> hppa-specific
>>> equivalent sysdeps/unix/sysv/linux/hppa/pthread.h.
>>>
>>> Rafal Luzynski spotted[2] typos in the NEWS entry and manual updates too.
>>>
>>> Florian Weimer spotted[3] that the clockid parameter was not using a
>>> reserved identifier in pthread.h.
>>>
>>> [1] https://sourceware.org/ml/libc-alpha/2019-11/msg00016.html
>>> [2] https://sourceware.org/ml/libc-alpha/2019-11/msg00019.html
>>> [3] https://sourceware.org/ml/libc-alpha/2019-11/msg00022.html
>>>
>>> Fixes: 69ca4b54c151cec42ccca5e05790efc1a8206b47
>>> ---
>>> NEWS | 2 +-
>>> manual/threads.texi | 2 +-
>>> sysdeps/nptl/pthread.h | 2 +-
>>> sysdeps/unix/sysv/linux/hppa/pthread.h | 11 +++++++++++
>>> 4 files changed, 14 insertions(+), 3 deletions(-)
>>> [...]
>>
>> LGTM but I'd like to hear a feedback from Joseph and Florian as well.
>
> This patch is OK.
>
Pushed upstream, thanks