This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 0/4] nptl: Add pthread_clockjoin_np
- From: Rafal Luzynski <digitalfreak at lingonborough dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Mike Crowe <mac at mcrowe dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Sat, 2 Nov 2019 00:01:37 +0100 (CET)
- Subject: Re: [PATCH v2 0/4] nptl: Add pthread_clockjoin_np
- References: <cover.3b6b26e85a044f5ad7494dfb035620d75eb57c63.1568809830.git-series.mac@mcrowe.com> <772950b2-f186-841f-b90a-203f40fc7906@linaro.org> <20191031193824.GA23256@mcrowe.com> <4b869359-3d4c-1cd1-8a55-37a396966b08@linaro.org>
Mike, Adhemerval,
This patch series contains this excerpt:
> commit 69ca4b54c151cec42ccca5e05790efc1a8206b47
> Author: Mike Crowe <mac@mcrowe.com>
> Date: Thu Oct 31 10:03:21 2019 -0300
>
> nptl: Add pthread_clockjoin_np
>
> Introduce pthread_clockjoin_np as a version of pthread_timedjoin_np
> that
> accepts a clockid_t parameter to indicate which clock the timeout
> should be
> measured against. This mirrors the recently-added POSIX-proposed
> "clock"
> wait functions.
>
> Checked on x86_64-linux-gnu.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> diff --git a/NEWS b/NEWS
> index 75b380c0f8..3006b1a8e4 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -34,6 +34,10 @@ Major new features:
> will always receive a 'struct timezone' whose tz_minuteswest and
> tz_dsttime fields are zero.
>
> +* The function pthread_clockjoin_np has been added, enabling join with a
> + terminated thread with an specific clock. It allows waiting against
I think: "with a specific" -^^
> [...]
> diff --git a/manual/threads.texi b/manual/threads.texi
> index c0b504dc1f..e40b55c090 100644
> --- a/manual/threads.texi
> +++ b/manual/threads.texi
> @@ -751,6 +751,18 @@ reached if the thread has not terminated by that time
> and return
> will wait forever in the same way as @code{pthread_join}.
> @end deftypefun
>
> +@comment pthread.h
> +@comment GNU extension
> +@deftypefun int pthread_clockjoin_np (pthread_t *@var{thread},
> + void **@var{thread_return},
> + clockid_t @var{clockid},
> + const struct timespec
> *@var{abstime})
> +@standards{GNU, pthread.h}
> +@safety{@prelim{}@mtsafe{}@asunsafe{@asulock{}}@acunsafe{@aculock{}}}
> +Behaves like @code{pthread_timedjoin_np} except that time absolute time
> in
Did you mean "that the absolute"? ----------------------^^^^
Regards,
Rafal