This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2] elf: Use nocancel pread64() instead of lseek()+read()
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Leandro Pereira <Leandro dot Pereira at microsoft dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Fri, 18 Oct 2019 16:02:22 -0400
- Subject: Re: [PATCH 2/2] elf: Use nocancel pread64() instead of lseek()+read()
- References: <MWHPR2101MB073287753F9E8D211AF49DD3E8DA0@MWHPR2101MB0732.namprd21.prod.outlook.com> <b6d92327-1add-d95a-6606-7a270bcbec55@redhat.com>
On 10/3/19 9:59 AM, Carlos O'Donell wrote:
> On 8/5/19 5:56 PM, Leandro Pereira wrote:
>> Transforms this, when linking in a shared object:
>>
>> openat(AT_FDCWD, "/lib64/libc.so.6", O_RDONLY|O_CLOEXEC) = 3
>> read(3, "\177ELF\2\1\1\3"..., 832) = 832
>> lseek(3, 792, SEEK_SET) = 792
>> read(3, "\4\0\0\0\24\0\0\0"..., 68) = 68
>> fstat(3, {st_mode=S_IFREG|0755, st_size=6699224, ...}) = 0
>> lseek(3, 792, SEEK_SET) = 792
>> read(3, "\4\0\0\0\24\0\0\0"..., 68) = 68
>> lseek(3, 864, SEEK_SET) = 864
>> read(3, "\4\0\0\0\20\0\0\0"..., 32) = 32
>>
>> Into this:
>>
>> openat(AT_FDCWD, "/lib64/libc.so.6", O_RDONLY|O_CLOEXEC) = 3
>> read(3, "\177ELF\2\1\1\3"..., 832) = 832
>> pread(3, "\4\0\0\0\24\0\0\0"..., 68, 792) = 68
>> fstat(3, {st_mode=S_IFREG|0755, st_size=6699224, ...}) = 0
>> pread(3, "\4\0\0\0\24\0\0\0"..., 68, 792) = 68
>> pread(3, "\4\0\0\0\20\0\0\0"..., 32, 864) = 32
>>
>> 2019-08-05 Leandro Pereira <leandro.pereira@microsoft.com>
>>
>> * elf/dl-load.c: Use __pread64_nocancel() instead of __lseek()+
>> __read_nocancel().
>> * sysdeps/x86/dl-prop.h: Likewise.
>
> OK for master. I'll push after testing with bmg. No regressions on x86_64.
>
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Pushed.
--
Cheers,
Carlos.