This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] Add nocancel version of pread64()
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Leandro Pereira <Leandro dot Pereira at microsoft dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Fri, 18 Oct 2019 16:02:05 -0400
- Subject: Re: [PATCH 1/2] Add nocancel version of pread64()
- References: <MWHPR2101MB0732AF4AE4ECE64CB603997BE8DA0@MWHPR2101MB0732.namprd21.prod.outlook.com> <08c520b9-6fd6-5d64-9674-12755c4c6ed1@redhat.com>
On 10/3/19 9:55 AM, Carlos O'Donell wrote:
> On 8/5/19 5:54 PM, Leandro Pereira wrote:
>> This is in preparation for changes in the dynamic linker so that pread() is used instead of lseek()+read().
>>
>> 2019-08-05 Leandro Pereira <leandro.pereira@microsoft.com>
>>
>> * sysdeps/generic/not-cancel.h: New macro.
>> * sysdeps/unix/sysv/linux/not-cancel.h: New macro.
>> * sysdeps/unix/sysv/linux/pread64_nocancel.c: Implement nocancel
>> version of pread64.
>> * sysdeps/unix/sysv/linux/Versions (GLIBC_PRIVATE): Add
>> __pread64_nocancel.
>> * sysdeps/unix/sysv/linux/Makefile: Reference pread64_nocancel.c.
>
> OK for master. I'll push after testing with bmg.
>
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Pushed.
--
Cheers,
Carlos.