This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Linux: Use mmap instead of malloc in dirent/tst-getdents64
On 28/06/2019 11:52, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> Alright, but my point is for usual 64-bit architecture (which the test
>> are actually exercised) mapping 4GB of memory shouldn't really be a
>> problem.
>
> Our z/VM guests have 2 GiB RAM assigned to them.
>
>> The change looks ok, I would just like to make is more explicit
>> that the tests passed, but not all sub-tests ran.
>
> It's just a warning, not FAIL_UNSUPPORTED:
>
> if (large_buffer == MAP_FAILED)
> printf ("warning: could not allocate %zu bytes of memory,"
> " subtests skipped\n", large_buffer_size);
>
> If you don't like that, we'd have to split it into a separate test, I
> think.
I think we are ok for now, maybe in future we might want to add a new
test return code (SKIP or something).