This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Linux: Use mmap instead of malloc in dirent/tst-getdents64

* Adhemerval Zanella:

> Alright, but my point is for usual 64-bit architecture (which the test
> are actually exercised) mapping 4GB of memory shouldn't really be a
> problem.

Our z/VM guests have 2 GiB RAM assigned to them.

> The change looks ok, I would just like to make is more explicit
> that the tests passed, but not all sub-tests ran.

It's just a warning, not FAIL_UNSUPPORTED:

      if (large_buffer == MAP_FAILED)
        printf ("warning: could not allocate %zu bytes of memory,"
                " subtests skipped\n", large_buffer_size);

If you don't like that, we'd have to split it into a separate test, I
think.

Thanks,
Florian
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]