This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2 v2] [powerpc] add 'volatile' to asm

"Paul A. Clarke" <pc@us.ibm.com> writes:

> Add 'volatile' keyword to a few asm statements, to force the compiler
> to generate the instructions therein.
>
> Some instances were implicitly volatile, but adding keyword for consistency.

This patch LGTM.
I have just one minor suggestion...

> @@ -101,7 +101,7 @@ typedef unsigned int fpu_control_t;
>      __u.__ll = 0xfff80000LL << 32; /* This is a QNaN.  */	\
>      __u.__ll |= (cw) & 0xffffffffLL;				\
>      __fr = __u.__d;						\
> -    __asm__ ("mtfsf 255,%0" : : "f" (__fr));			\
> +    __asm__ __volatile__("mtfsf 255,%0" : : "f" (__fr));			\

The indentation at the EOL is broken.  Needs to remove a tab  --^

-- 
Tulio Magno
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]