This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] <sys/stat.h>: Use Linux kernel UAPI header if available and useful


* Andreas Schwab:

> On Jun 11 2019, Florian Weimer <fweimer@redhat.com> wrote:
>
>> * Andreas Schwab:
>>
>>> On Jun 11 2019, Florian Weimer <fweimer@redhat.com> wrote:
>>>
>>>> So should we write statx_generic in such a way that it does not depend
>>>> on the size of struct stax?
>>>
>>> The fallback uses the original definition, and must never write beyond
>>> that.
>>
>> The question is whether we achieve this with a separate struct type, or
>> by changing it so that it only writes to all the fields in the original
>> definition (i.e., remove the struct assigned and write to all members
>> explicitly, including those that need to be zeroed).
>
> Since we already have that separate type, using that would be the
> cleanest.

This will need preprocessor hacks.  I don't think there is another way
to rename a struct tag.  It also doesn't help that the tag is the same
as a function name.

Do we really want to move in this direction?

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]