This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] <sys/stat.h>: Use Linux kernel UAPI header if available and useful
* Andreas Schwab:
> On Jun 11 2019, Florian Weimer <fweimer@redhat.com> wrote:
>
>> We can either duplicate the struct definition (like we did before this
>> change), or add the assert, so that we are told once the duplication
>> becomes necessary. I slightly prefer the second approach.
>
> Duplication looks like the cleanest approach, since the fallback never
> wants to use a different one. It will use the original definition
> forever.
Ideally, we would still write a test that the duplicate and the kernel
version match, and that is kind of hard.
I will come up with a patch with the duplication and remove the asssert.
However, I do not really like it. At this point, we don't know if we
will ever actually need the duplicate.
Thanks,
Florian