This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v4 02/11] nds32: ABI Implementation
On Fri, Jun 07, 2019 at 06:37:28AM +0800, Joseph Myers wrote:
> On Wed, 5 Jun 2019, Vincent Chen wrote:
>
> > diff --git a/locale/Makefile b/locale/Makefile
> > index 0ad99ec..803a3a5 100644
> > --- a/locale/Makefile
> > +++ b/locale/Makefile
> > @@ -113,5 +113,5 @@ lib := locale-programs
> > include $(patsubst %,$(..)libof-iterator.mk,$(cpp-srcs-left))
> >
> > $(objpfx)tst-locale-locpath.out : tst-locale-locpath.sh $(objpfx)locale
> > - $(SHELL) $< '$(common-objpfx)' '$(test-wrapper)' '$(test-wrapper-env)' > $@; \
> > + $(SHELL) $< '$(common-objpfx)' '$(test-wrapper-env)' '$(run_program_env)'> $@; \
> > $(evaluate-test)
>
> Never mix this sort of architecture-independent patch into an
> architecture-specific one; post separately with its own justification.
>
This modification is for self-testing, and I accidentally included it
in this patchset. I will remove it in the next submission.
> > + } __jmp_buf[1] __attribute__((__aligned__ (8)));
>
> Example of a coding style issue, missing space before '(' (fix everywhere
> in this series).
>
OK, I will fix it.
Thanks,
Vincent