This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v4 02/11] nds32: ABI Implementation

From: Joseph Myers <joseph at codesourcery dot com>
To: Vincent Chen <vincentc at andestech dot com>
Cc: <libc-alpha at sourceware dot org>, <deanbo422 at gmail dot com>, <cnoize at andestech dot com>
Date: Thu, 6 Jun 2019 22:37:28 +0000
Subject: Re: [PATCH v4 02/11] nds32: ABI Implementation
References: <1559735815-20093-1-git-send-email-vincentc@andestech.com> <1559735815-20093-3-git-send-email-vincentc@andestech.com>

On Wed, 5 Jun 2019, Vincent Chen wrote:

> diff --git a/locale/Makefile b/locale/Makefile
> index 0ad99ec..803a3a5 100644
> --- a/locale/Makefile
> +++ b/locale/Makefile
> @@ -113,5 +113,5 @@ lib := locale-programs
>  include $(patsubst %,$(..)libof-iterator.mk,$(cpp-srcs-left))
>  
>  $(objpfx)tst-locale-locpath.out : tst-locale-locpath.sh $(objpfx)locale
> -	$(SHELL) $< '$(common-objpfx)' '$(test-wrapper)' '$(test-wrapper-env)' > $@; \
> +	$(SHELL) $< '$(common-objpfx)' '$(test-wrapper-env)' '$(run_program_env)'> $@; \
>  	$(evaluate-test)

Never mix this sort of architecture-independent patch into an 
architecture-specific one; post separately with its own justification.

> +  } __jmp_buf[1] __attribute__((__aligned__ (8)));

Example of a coding style issue, missing space before '(' (fix everywhere 
in this series).

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- Re: [PATCH v4 02/11] nds32: ABI Implementation
  - From: Vincent Chen

References:
- [PATCH v4 00/11] nds32 glibc port, v4
  - From: Vincent Chen
- [PATCH v4 02/11] nds32: ABI Implementation
  - From: Vincent Chen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]