This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/5] sysvipc: Move __IPC_64 to kernel-features.h
On 20/05/2019 09:30, Adhemerval Zanella wrote:
>
>
> On 20/05/2019 09:20, Andreas Schwab wrote:
>> On Mai 20 2019, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
>>
>>> I don't a strong preference here, one option is to parametrize even more
>>> the __IPC_64 with another flag that set/unset by kernel-features.h and
>>> then handled by ipc-priv.h or whatever. However I think this is more
>>> unnecessary complexity.
>>
>> Can't you use __ASSUME_DIRECT_SYSVIPC_SYSCALLS for that?
>>
>
> I think it feasible, I will adjust the patchset.
>
In fact the problem is __ASSUME_DIRECT_SYSVIPC_SYSCALLS does not hold
all the information. Alpha, arm, microblaze, mips-n{32,64}, and nios
assumes the default of __ASSUME_DIRECT_SYSVIPC_SYSCALLS, but requires
__IPC_64 set to 0x100.
While the newly added wire-up for i686, m68k, mips-o32, powerpc, s390,
and sparc requires would require __IPC_64 set to 0x100. That's why
we will need to set __IPC_64 as architecture base or add an extra
__ASSUME flag to export this information. I don't have a preference
here, assuming __IPC_64 is either 0x0 or 0x100 we can just set the
default value of 0x0 with a __ASSUME_SYSVIPC_DEFAULT_IPC_64 and
undef on the required architectures to use 0x100.