This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/5] sysvipc: Move __IPC_64 to kernel-features.h
On Mai 16 2019, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
> In file included from ../sysdeps/unix/sysv/linux/arm/kernel-features.h:23,
> from ../sysdeps/unix/sysv/linux/lowlevellock-futex.h:25,
> from ../sysdeps/nptl/lowlevellock.h:23,
> from ../nptl/descr.h:29,
> from ../sysdeps/arm/nptl/tls.h:42,
> from ../sysdeps/unix/sysv/linux/arm/tls.h:23,
> from ../sysdeps/unix/sysv/linux/arm/sysdep.h:33,
> from <stdin>:2:
> ../sysdeps/unix/sysv/linux/kernel-features.h:83: error: "__IPC_64" redefined [-Werror]
> #define __IPC_64 0x0
>
> In file included from ../sysdeps/unix/sysv/linux/sysdep.h:19,
> from ../sysdeps/unix/sysv/linux/arm/sysdep.h:27,
> from <stdin>:2:
> ../sysdeps/unix/sysv/linux/arm/kernel-features.h:58: note: this is the location of the previous definition
> #define __IPC_64 0x100
I think trying to put __IPC_64 in kernel-features.h is the wrong way to
solve this.
> In general I think unguarded headers file are error-prone.
kernel-features.h is special since it is chain-loaded.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."