This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v7 1/2] strftime: Set the default width of "%Ey" to 2 [BZ #23758]


17.01.2019 07:38 TAMUKI Shoichi <tamuki@linet.gr.jp> wrote:
> In Japanese locales, strftime's alternative year format (%Ey) produces
> the year of the current era (Japanese calendar).

As I wrote in my previous email, the term "Japanese calendar" may be
incorrect here.

Now I can see that neither of our comments may be correct.  "%Ey" produces
the number of the year within the current era.  It says which (numbered)
year of the current era is now.  Is "nengo" a correct name for this?
Should we maybe drop this parentheses completely, including its content?

I don't quote the rest of your patch here as it looks correct to me,
looking at previous comments from Zack and Paul.  Please rethink this
minor issue in the commit message and/or maybe let's wait for Zack's
or Paul's comment about it and it will be OK for me to commit this.

Regards,

Rafal


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]