Re: 2.29 freeze update: Last fortnight

[Paul Eggert <eggert at cs dot ucla dot edu>]

On 1/15/19 9:16 AM, Rafal Luzynski wrote:
> https://sourceware.org/ml/libc-alpha/2019-01/msg00239.html

I took a look at those. Some comments:

>+ For %Ey conversion specifier, the default action is now
>+ to pad the number with zero to keep minimum 2 digits, similar to %y.

Change to:

The default for %Ey is now to zero-pad to two digits, like %y.


>+The default action is to pad the number with zero to keep minimum 2
>+digits, similar to @code{%y}.

Change to:

By default this is zero-padded to two digits, like @code{%y}.

>  For %Ey conversion specifier, the default action is now
>  to pad the number with zero to keep minimum 2 digits, similar to %y.
>+ Also, the optional flag (either _ or -) can be used for %EY, so that
>+ the internal %Ey is interpreted as if decorated with the appropriate
>+ flag.

Change to:

For the %Ey conversion specifier, the default action is now to zero-pad 
the number to two digits, like %y.  Also, the optional flag (either _ or 
-) now affects the formatted year, like %EY.


> static size_t __strftime_internal (CHAR_T *, size_t, const CHAR_T *,
>-                   const struct tm *, bool *
>+                   const struct tm *, int *, bool *
>                    ut_argument_spec
>                    LOCALE_PARAM) __THROW;

I also am puzzled as to why the new argument is int * rather than plain 
int. Why not make it plain int and simplify the rest of the code 
accordingly?