Re: 2.29 freeze update: Last fortnight

[Rafal Luzynski <digitalfreak at lingonborough dot com>]

15.01.2019 18:02 Zack Weinberg <zackw@panix.com> wrote:
> On Tue, Jan 15, 2019 at 11:53 AM Rafal Luzynski
> <digitalfreak@lingonborough.com> wrote:
> > [...]
> > 1. There are documentation changes which I hesitate to review because
> >    I think this should be done by a native English speaker (or anyone
> >    having equivalently perfect knowledge of English language).
> 
> I can review them if you reply to this email with the archive URL(s)
> of the most recent version(s) of the documentation patch(es).
> [...]

The most recent version is here:

https://sourceware.org/ml/libc-alpha/2019-01/msg00239.html

+ 2 followups.

See also my previous review which could have led to the current
version:

https://sourceware.org/ml/libc-alpha/2018-12/msg00999.html

> > 2. I still don't understand why the newly added argument of
> >    __strftime_internal yr_spec is of the type "int *" rather than just
> >    "int".  Maybe it is correct and the reason is that I have not
> >    analyzed it carefully enough.  I'm sorry, I am unable to analyze
> >    it more carefully this week.
> 
> Unfortunately I don't know enough about the guts of strftime to help
> with this part.

That's OK, if you review the documentation part your help will be huge
already.  I hope there are more people who are able to analyze this
part including myself (if I only have more time).

Regards,

Rafal