This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v6] strftime: Consequently use the "L_" macro with character literals
- From: TAMUKI Shoichi <tamuki at linet dot gr dot jp>
- To: Rafal Luzynski <digitalfreak at lingonborough dot com>, libc-alpha at sourceware dot org
- Date: Sat, 12 Jan 2019 22:04:15 +0900
- Subject: Re: [PATCH v6] strftime: Consequently use the "L_" macro with character literals
- References: <673748906.251926.1547247837999@poczta.nazwa.pl>
Hello Rafal,
From: Rafal Luzynski <digitalfreak@lingonborough.com>
Subject: Re: [PATCH v6] strftime: Consequently use the "L_" macro with character literals
Date: Sat, 12 Jan 2019 00:03:57 +0100 (CET)
> I understood Siddhesh' suggestion [1] as the request for me to push
> this patch and I have pushed it now with minor changes in the commit
> message. I have given up on the requirement of the trailing dot in
> the first line for now.
Thank you for pushing my patch with minor changes in the commit
message.
Yes, I prefer not to end the first line with a period, because it is a
title and titles do not end with a period.
There is not a firm rule in Glibc Wiki, indeed. On the other hand, it
commonly seems that the summary line of commit message should not end
with a period. (Googling "git commit summary period".)
Regards,
TAMUKI Shoichi