This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] resolv: AAAA (28) is valid, no fallthrough to default
- From: Florian Weimer <fweimer at redhat dot com>
- To: Andreas K. Hüttel <dilfridge at gentoo dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 10 Jan 2019 12:00:08 +0100
- Subject: Re: [PATCH] resolv: AAAA (28) is valid, no fallthrough to default
- References: <20190110001717.25717-1-dilfridge@gentoo.org>
* Andreas K. Hüttel:
> The test resolv/tst-resolv-ai_idn-nolibidn2 kept failing, with the puzzling
> output "invalid qtype: 28". Puzzling since 28 is an AAAA record.
> Turns out the switch statement is missing a break, so the "T_AAAA" case
> continues with "default".
> ---
> resolv/tst-resolv-ai_idn-common.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/resolv/tst-resolv-ai_idn-common.c b/resolv/tst-resolv-ai_idn-common.c
> index bb81c2ca23..61cc81b71f 100644
> --- a/resolv/tst-resolv-ai_idn-common.c
> +++ b/resolv/tst-resolv-ai_idn-common.c
> @@ -241,6 +241,7 @@ response (const struct resolv_response_context *ctx,
> qname[0] };
> resolv_response_add_data (b, &addr, sizeof (addr));
> }
> + break;
> default:
> FAIL_EXIT1 ("invalid qtype: %d", qtype);
> }
The change is obviously correct. I will commit it for you.
However, how do you encounter this issue? Did you change some test?
The current IDN tests do not actually send AAAA queries, I think.
Thanks,
Florian