This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH] resolv: AAAA (28) is valid, no fallthrough to default
- From: Andreas K. Hüttel <dilfridge at gentoo dot org>
- To: libc-alpha at sourceware dot org
- Cc: Andreas K. Hüttel <dilfridge at gentoo dot org>
- Date: Thu, 10 Jan 2019 01:17:17 +0100
- Subject: [PATCH] resolv: AAAA (28) is valid, no fallthrough to default
The test resolv/tst-resolv-ai_idn-nolibidn2 kept failing, with the puzzling
output "invalid qtype: 28". Puzzling since 28 is an AAAA record.
Turns out the switch statement is missing a break, so the "T_AAAA" case
continues with "default".
---
resolv/tst-resolv-ai_idn-common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/resolv/tst-resolv-ai_idn-common.c b/resolv/tst-resolv-ai_idn-common.c
index bb81c2ca23..61cc81b71f 100644
--- a/resolv/tst-resolv-ai_idn-common.c
+++ b/resolv/tst-resolv-ai_idn-common.c
@@ -241,6 +241,7 @@ response (const struct resolv_response_context *ctx,
qname[0] };
resolv_response_add_data (b, &addr, sizeof (addr));
}
+ break;
default:
FAIL_EXIT1 ("invalid qtype: %d", qtype);
}
--
2.20.1