This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 14/21] ARC: Enable __start as entry point vs. canonical _start
On 12/18/18 2:59 PM, Joseph Myers wrote:
>> I deliberately kept them out to call out the fixes, sometimes these help
>> new ports which stumble into similar issues. And also ~2 years worth of
>> work gets squashed into a single blob is a shame :-)
>
> Postings of a new port should generally post each new file in the form in
> which it is intended to be committed (and, thus, the form in which it
> should be reviewed); you should never post a known-buggy version and a
> subsequent fix to the bug; that wastes reviewers' time. (The actual
> commit of the port should be a single commit with everything, modulo
> possible separate earlier commits for changes to architecture-independent
> files, as the port isn't useful with only a subset of the new files
> added.
Ok I can certainly squash them in next version.
Thx,
-Vineet