Re: [PATCH 14/21] ARC: Enable __start as entry point vs. canonical _start

[Joseph Myers <joseph at codesourcery dot com>]

On Tue, 18 Dec 2018, Vineet Gupta wrote:

> On 12/18/18 1:28 PM, Florian Weimer wrote:
> >> ARC linker scripts have defined __start as entry point so to not break
> >> ABI for uClibc et al we allow __start for glibc as well
> > I think this change and the test suite fixes should be folded into the
> > initial addition of these files.  Or is there a reason for not doing
> > this?
> 
> I deliberately kept them out to call out the fixes, sometimes these help 
> new ports which stumble into similar issues. And also ~2 years worth of 
> work gets squashed into a single blob is a shame :-)

Postings of a new port should generally post each new file in the form in 
which it is intended to be committed (and, thus, the form in which it 
should be reviewed); you should never post a known-buggy version and a 
subsequent fix to the bug; that wastes reviewers' time.  (The actual 
commit of the port should be a single commit with everything, modulo 
possible separate earlier commits for changes to architecture-independent 
files, as the port isn't useful with only a subset of the new files 
added.)

-- 
Joseph S. Myers
joseph@codesourcery.com