This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] argp: do not call _IO_fwide() if _LIBC is not defined

From: Couret Charles-Antoine <charles-antoine dot couret at essensium dot com>
To: Joseph Myers <joseph at codesourcery dot com>, Zack Weinberg <zackw at panix dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Wed, 28 Nov 2018 18:25:51 +0100
Subject: Re: [PATCH] argp: do not call _IO_fwide() if _LIBC is not defined
References: <20181128114839.5680-1-charles-antoine.couret@essensium.com> <alpine.DEB.2.21.1811281650070.5954@digraph.polyomino.org.uk> <CAKCAbMieBGDXeze591Ekxk9EhYRM6stzeeHWt25-MFozt=qHzA@mail.gmail.com> <alpine.DEB.2.21.1811281707300.5954@digraph.polyomino.org.uk>

Hi,

BTW I was not aware about differences between glibc and gnulib.

I checked the current code of gnulib and in fact they already made thischange in the past.

See:http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=14a582531cef13c855c9e9638aac630c0a43ae37

And apparently the difference exists also in misc/err.c file, in glibcthe include is not protected (and _IO_fwide() too) but in gnulib thesame preprocessor instruction protects the header inclusion and thefunction call.


Regards,

Charles-Antoine

References:
- [PATCH] argp: do not call _IO_fwide() if _LIBC is not defined
  - From: Charles-Antoine Couret
- Re: [PATCH] argp: do not call _IO_fwide() if _LIBC is not defined
  - From: Joseph Myers
- Re: [PATCH] argp: do not call _IO_fwide() if _LIBC is not defined
  - From: Zack Weinberg
- Re: [PATCH] argp: do not call _IO_fwide() if _LIBC is not defined
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]