This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] add support for GCC 9 attribute copy


On Mon, 12 Nov 2018, Martin Sebor wrote:

> Attribute copy calls decl_attributes to copy tls_model from
> __sim_exceptions_thread to __EI___sim_exceptions_thread.  That
> triggers a warning because
> DECL_THREAD_LOCAL_P (__EI___sim_exceptions_thread) is false.
> I think __EI___sim_exceptions_thread needs to be declared
> thread-local (just like __sim_exceptions_thread) for this
> to work.  Can you think of something better?

I've now applied a patch to add hidden_tls_def macros to deal with this.

> Let me know if you see a problem with suppressing the warning
> in Glibc.

I've now applied a patch to stop the MIPS case using strong_alias at all 
so that it doesn't get the copy attribute used.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]