This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] add support for GCC 9 attribute copy

On Sun, 11 Nov 2018, Martin Sebor wrote:

> I should have mentioned this up front: the patch only avoids warnings
> in the x86_64 files (and was only tested there). It doesn't touch
> files for any other targets and (as Jeff just noted to me privately)
> there are warnings in builds for some non-x86_64 targets, including
> i686.  This is not unexpected and those targets will need tweaks
> similar to those in the patch.  Joseph, let me know if you need my
> help with any of it.

Could you look at the powerpc soft-float, s390x and mips failures, which 
look somewhat different (and thus could indicate issues with the details 
of how this warning / attribute are specified, as opposed to simply 
needing a few more copy attributes somewhere)?

powerpc soft-float:

../sysdeps/powerpc/nofpu/sim-full.c:26:1: error: 'tls_model' attribute ignored [-Werror=attributes]
   26 | libc_hidden_data_def (__sim_exceptions_thread);
      | ^~~~~~~~~~~~~~~~~~~~
../sysdeps/powerpc/nofpu/sim-full.c:30:1: error: 'tls_model' attribute ignored [-Werror=attributes]
   30 | libc_hidden_data_def (__sim_disabled_exceptions_thread);
      | ^~~~~~~~~~~~~~~~~~~~
../sysdeps/powerpc/nofpu/sim-full.c:33:1: error: 'tls_model' attribute ignored [-Werror=attributes]
   33 | libc_hidden_data_def (__sim_round_mode_thread);
      | ^~~~~~~~~~~~~~~~~~~~

s390x produces a long series of errors starting with:

../sysdeps/s390/multiarch/utf8-utf16-z9.c:26:18: error: always_inline function might not be inlinable [-Werror=attributes]

mips (o32) produces:

../sysdeps/mips/__longjmp.c:84:1: error: '__longjmp' redeclared with conflicting 'nomips16' attributes
   84 | strong_alias (____longjmp, __longjmp);
      | ^~~~~~~~~~~~

and in this case I think it's clearly correct for ____longjmp 
(ABI-specific definition) to have the attribute, but the alias __longjmp 
(declared in an architecture-independent header) not to have it in that 
header (and so shouldn't get it copied either).

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]