This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v12 1/3] Y2038: provide size of default time_t for target architecture
Hi Florian,
On Wed, 24 Oct 2018 11:24:25 +0200, Florian Weimer <fweimer@redhat.com>
wrote :
> * Albert ARIBAUD:
>
> > Hi Florian,
> >
> > On Wed, 24 Oct 2018 10:01:04 +0200, Florian Weimer <fweimer@redhat.com>
> > wrote :
> >
> >> * Albert ARIBAUD:
> >>
> [...]
> [...]
> [...]
> >>
> >> I think the ChangeLog should list the names of macros being changed, so
> >> something like thiss:
> >>
> >> * sysdeps/unix/sysv/linux/mips/bits/msq-pad.h
> >> (__MSQ_PAD_AFTER_TIME, __SHM_PAD_BETWEEN_TIME_AND_SEGSZ): Use
> >> __TIMESIZE instead of __WORDSIZE.
> >
> > Thanks, I've rewritten the ChangeLog file (and the commit message
> > changelog part for homogeneity) based on your example -- listing the
> > right macro(s) for each header file of course.
>
> Please update the data in the ChangeLog and the commit (git commit
> --amend --date="`date`"), rebase to current master, and then you should
> be okay to push to the official master branch.
Ok.
> (I assume this patch has actually been reviewed, I have not checked
> that. 8-)
Yes it has. :)
> Thanks,
> Florian
Cordialement,
Albert ARIBAUD
3ADEV