This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Improve the width of alternate representation for year in strftime [BZ #23758]

From: Florian Weimer <fweimer at redhat dot com>
To: Rafal Luzynski <digitalfreak at lingonborough dot com>
Cc: TAMUKI Shoichi <tamuki at linet dot gr dot jp>, libc-alpha at sourceware dot org
Date: Wed, 24 Oct 2018 09:55:18 +0200
Subject: Re: [PATCH] Improve the width of alternate representation for year in strftime [BZ #23758]
References: <201810112107.AA04060@tamuki.linet.gr.jp> <877ei8vn6b.fsf@oldenburg.str.redhat.com> <7822749.52817.1540325590834@poczta.nazwa.pl>

* Rafal Luzynski:

> 23.10.2018 14:54 Florian Weimer <fweimer@redhat.com> wrote:
>> [...]
>> This should also avoid the need for new memory allocations.
>> 
>> Thanks,
>> Florian
>
> While at this, Florian, I think you tried to eliminate all occurrences
> of alloca family functions in the past.  I can see that Tamuki Shoichi's
> patch uses alloca family optionally.  Shouldn't this patch just assume
> that alloca is never used, and using_malloc is always true and therefore
> can be dropped?  The patch would be simpler and IIUC more secure.

Right, that's why I suggested not to rewrite the format string.  Then
the alloca will be gone because the copy is not needed.

Thanks,
Florian

References:
- [PATCH] Improve the width of alternate representation for year in strftime [BZ #23758]
  - From: TAMUKI Shoichi
- Re: [PATCH] Improve the width of alternate representation for year in strftime [BZ #23758]
  - From: Florian Weimer
- Re: [PATCH] Improve the width of alternate representation for year in strftime [BZ #23758]
  - From: Rafal Luzynski

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]