This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Improve the width of alternate representation for year in strftime [BZ #23758]
- From: Rafal Luzynski <digitalfreak at lingonborough dot com>
- To: Florian Weimer <fweimer at redhat dot com>, TAMUKI Shoichi <tamuki at linet dot gr dot jp>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 23 Oct 2018 22:13:10 +0200 (CEST)
- Subject: Re: [PATCH] Improve the width of alternate representation for year in strftime [BZ #23758]
- References: <201810112107.AA04060@tamuki.linet.gr.jp> <877ei8vn6b.fsf@oldenburg.str.redhat.com>
23.10.2018 14:54 Florian Weimer <fweimer@redhat.com> wrote:
> [...]
> This should also avoid the need for new memory allocations.
>
> Thanks,
> Florian
While at this, Florian, I think you tried to eliminate all occurrences
of alloca family functions in the past. I can see that Tamuki Shoichi's
patch uses alloca family optionally. Shouldn't this patch just assume
that alloca is never used, and using_malloc is always true and therefore
can be dropped? The patch would be simpler and IIUC more secure.
Regards,
Rafal