This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] time/tst-mktime2: Improve test error reporting
- From: "Gabriel F. T. Gomes" <gabriel at inconstante dot eti dot br>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 22 Oct 2018 11:51:45 -0300
- Subject: Re: [PATCH] time/tst-mktime2: Improve test error reporting
- References: <87r2gm9fom.fsf@oldenburg.str.redhat.com>
On Fri, 19 Oct 2018, Florian Weimer wrote:
>2018-10-19 Florian Weimer <fweimer@redhat.com>
>
> * time/tst-mktime2.c (N_STRINGS): Remove.
> (set_timezone): New function.
> (spring_forward_gap): Call it. Use FAIL_EXIT1.
> (mktime_test1): Report localtime failure and check errno value.
> Use TEST_COMPARE.
> (irix_6_4_bug, bigtime_test): Use TEST_COMPARE.
> (do_test): Remove alarm call. Use set_timezone and array_length.
Looks good to me.