This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Increase timeout of libio/tst-readline
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Szabolcs Nagy <Szabolcs dot Nagy at arm dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Cc: nd <nd at arm dot com>
- Date: Tue, 9 Oct 2018 10:50:19 -0400
- Subject: Re: [PATCH] Increase timeout of libio/tst-readline
- References: <e9960b99-c83a-d0ae-1fda-3610e3f1bd32@arm.com>
On 10/9/18 10:19 AM, Szabolcs Nagy wrote:
> Increase timeout from the default 20s to 100s. This test makes close to
> 20 million syscalls with distribution:
>
> 12327675 read
> 4143204 lseek
> 929475 close
> 929471 openat
> 92817 fstat
> 1431 write
> ...
>
> The default timeout assumes each can finish in 1us on average which
> is not true on slow machines.
>
> 2018-10-09 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> * libio/tst-readline.c (TIMEOUT): Define.
>
OK for master. I think 100s is OK, particularly because on fast machines
the test will be fast, and it's unlikely to be slowed down by anything
or get stuck anywhere (no poll/epoll usage etc).
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.