This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH v8 2/2] Y2038: make __tz_convert compatible with 64-bit-time
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Albert ARIBAUD <albert dot aribaud at 3adev dot fr>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 4 Oct 2018 12:14:46 +0000
- Subject: Re: [PATCH v8 2/2] Y2038: make __tz_convert compatible with 64-bit-time
- References: <email@example.com> <firstname.lastname@example.org> <alpine.DEB.email@example.com> <20180929134108.5a4548a6@athena> <alpine.DEB.firstname.lastname@example.org> <20181004130900.26988e0d@athena>
On Thu, 4 Oct 2018, Albert ARIBAUD wrote:
> Which I assume is fine, as the two FAILs are the libidn2 ones.
Yes, those results are fine.
> I take this result as a reference and am running make check now on
> patches applied above release/2.28/master; If the results are the
> same as the reference, I'll consider the patches good for resubmission.
Note that you should test for a 32-bit configuration as well - this
applies to pretty much all the patches for 64-bit time, they need testing
for both 32-bit and 64-bit configurations (some will need other testing,
e.g. with kernels with the Y2038 patches included, but that doesn't apply
to this one).
It should be possible to test natively for 32-bit on a 64-bit system if
you install the relevant OS packages for 32-bit libraries (including
development packages), and specify CC="gcc -m32" CXX="g++ -m32" when
configuring for i686-pc-linux-gnu, but I haven't tried that using OS
compiler packages (I test natively for 32-bit on a 64-bit system, but
using locally built compilers).
Joseph S. Myers