Re: [PATCH v8 2/2] Y2038: make __tz_convert compatible with 64-bit-time

[Albert ARIBAUD <albert dot aribaud at 3adev dot fr>]

Hi Joseph,

Le Sun, 30 Sep 2018 13:37:58 +0000, Joseph Myers
<joseph@codesourcery.com> a écrit :

> On Sat, 29 Sep 2018, Albert ARIBAUD wrote:
> 
> > > [...]
> > > Summary of test results:                                       
> > >     132 FAIL
> > >    5788 PASS
> > >      11 UNSUPPORTED
> > >      17 XFAIL
> > >       2 XPASS
> > > Makefile:345: recipe for target 'tests' failed
> > > make[1]: *** [tests] Error 1
> > > make[1] : on quitte le répertoire « /home/3adev/glibc/src »
> > > Makefile:9: recipe for target 'check' failed
> > > make: *** [check] Error 2  
> > 
> > Is it normal that the make check fail with a non-zero number of FAIL and
> > XFAIL?  
> 
> You should expect XFAILs (for example, for conform/ tests that 
> deliberately test features of the relevant standard that are either not 
> provided by glibc, or are deliberately unsupported).
> 
> You should not expect anything like 132 FAILs; you'll need to get a 
> working configuration for testing without so many FAILs on unmodified 
> sources before you can effectively test proposed patches.
> 
> > Is it is a normal result (i.e. this release of glibc is known to FAIL
> > and XFAIL this way for x86_64), then where can I find the expected FAIL
> > and XFAIL details for a given architecture and a given release of glibc?  
> 
> See the per-release wiki pages, e.g. 
> <https://sourceware.org/glibc/wiki/Release/2.28>.  That shows 17 XFAILs as 
> expected for x86_64, but no FAILs.  (Ignore the results for WSL - the 
> Windows subsystem for Linux emulation - all they show is defects in that 
> subsystem, it's not a suitable environment for normal glibc testing.)
> 
> On Ubuntu 18.04 (using a locally built compiler - if you do that, note you 
> need to copy libgcc_s.so.* and libstdc++.so.* into the build directory 
> before running the tests) I get two FAILs:
> 
> FAIL: resolv/tst-resolv-ai_idn
> FAIL: resolv/tst-resolv-ai_idn-latin1
> 
> Those appear in the architecture-independent section of the wiki page, for 
> systems with too-old libidn2.
> 
> For 32-bit testing on 64-bit Ubuntu 18.04 (again, with a locally built 
> compiler) I get one FAIL:
> 
> FAIL: nss/tst-nss-test3

I'd run make check in the past without these errors, hence my surprise.
Apparently, the issue lies with the value of --prefix at configure
time; It was not /usr, whereas if it is, and on a X86_64 machine, I do:

    mkdir temp
    cd temp
    git clone git://sourceware.org/git/glibc.git src
    cd src
    git checkout origin/release/2.28/master
    cd ..
    mkdir build
    cd build
    ./configure --prefix=/usr
    make
    make check

I end up with

UNSUPPORTED: elf/tst-audit10
UNSUPPORTED: elf/tst-avx512
XPASS: elf/tst-protected1a
XPASS: elf/tst-protected1b
UNSUPPORTED: math/test-double-libmvec-alias-avx512
UNSUPPORTED: math/test-double-libmvec-alias-avx512-main
UNSUPPORTED: math/test-double-libmvec-sincos-avx512
UNSUPPORTED: math/test-float-libmvec-alias-avx512
UNSUPPORTED: math/test-float-libmvec-alias-avx512-main
UNSUPPORTED: math/test-float-libmvec-sincosf-avx512
UNSUPPORTED: misc/tst-pkey
FAIL: resolv/tst-resolv-ai_idn
FAIL: resolv/tst-resolv-ai_idn-latin1
Summary of test results:
      2 FAIL
   5924 PASS
      9 UNSUPPORTED
     17 XFAIL
      2 XPASS

Which I assume is fine, as the two FAILs are the libidn2 ones.

I take this result as a reference and am running make check now on
patches applied above release/2.28/master; If the results are the
same as the reference, I'll consider the patches good for resubmission.

Cordialement,
Albert ARIBAUD
3ADEV