This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] x86: Use RTM intrinsics in pthread mutex lock elision
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Tue, 2 Oct 2018 10:06:10 -0300
- Subject: Re: [PATCH] x86: Use RTM intrinsics in pthread mutex lock elision
- References: <20181001220831.7420-1-hjl.tools@gmail.com>
On 01/10/2018 19:08, H.J. Lu wrote:
> Since RTM intrinsics are supported in GCC 4.9, we can use them in
> pthread mutex lock elision.
>
> * sysdeps/unix/sysv/linux/x86/Makefile (CFLAGS-elision-lock.c):
> Add -mrtm.
> (CFLAGS-elision-unlock.c): Likewise.
> (CFLAGS-elision-timed.c): Likewise.
> (CFLAGS-elision-trylock.c): Likewise.
> * sysdeps/unix/sysv/linux/x86/hle.h: Rewritten.
LGTM, thanks.
> ---
> sysdeps/unix/sysv/linux/x86/Makefile | 4 ++
> sysdeps/unix/sysv/linux/x86/hle.h | 70 ++--------------------------
> 2 files changed, 7 insertions(+), 67 deletions(-)
>
> diff --git a/sysdeps/unix/sysv/linux/x86/Makefile b/sysdeps/unix/sysv/linux/x86/Makefile
> index 7dc4e61756..02ca36c6d2 100644
> --- a/sysdeps/unix/sysv/linux/x86/Makefile
> +++ b/sysdeps/unix/sysv/linux/x86/Makefile
> @@ -14,6 +14,10 @@ endif
> ifeq ($(subdir),nptl)
> libpthread-sysdep_routines += elision-lock elision-unlock elision-timed \
> elision-trylock
> +CFLAGS-elision-lock.c += -mrtm
> +CFLAGS-elision-unlock.c += -mrtm
> +CFLAGS-elision-timed.c += -mrtm
> +CFLAGS-elision-trylock.c += -mrtm
> endif
>
> ifeq ($(subdir),elf)
> diff --git a/sysdeps/unix/sysv/linux/x86/hle.h b/sysdeps/unix/sysv/linux/x86/hle.h
> index 4a7b9e3bf7..0449026839 100644
> --- a/sysdeps/unix/sysv/linux/x86/hle.h
> +++ b/sysdeps/unix/sysv/linux/x86/hle.h
> @@ -1,75 +1,11 @@
> -/* Shared RTM header. Emulate TSX intrinsics for compilers and assemblers
> - that do not support the intrinsics and instructions yet. */
> +/* Shared RTM header. */
> #ifndef _HLE_H
> #define _HLE_H 1
>
> -#ifdef __ASSEMBLER__
> +#include <x86intrin.h>
Is it used in any configuration in assembly code?