This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] libio: Flush stream at freopen (BZ#21037)



On 02/10/2018 07:39, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>> diff --git a/libio/tst-memstream4.c b/libio/tst-memstream4.c
>> new file mode 100644
>> index 0000000000..bb2635e837
>> --- /dev/null
>> +++ b/libio/tst-memstream4.c
> 
>> +    //TEST_VERIFY (STRCMP (buf, W("new")) == 0);

Ugh, I will fix it.

> 
> This looks like a leftover.
> 
>> +    TEST_COMPARE_BLOB (buf, STRLEN (buf), W("new"), STRLEN (W ("new")));
> 
> I think you need STRLNE (buf) * sizeof (CHAR_T) here.
> 

Indeed, thanks for check on this.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]