This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH v8 2/2] Y2038: make __tz_convert compatible with 64-bit-time
On Wed, 26 Sep 2018, Albert ARIBAUD (3ADEV) wrote:
> Now that __time_64_t exists, we can switch internal function
> __tz_convert from 32-bit to 64-bit time. This involves switching
> some other internal functions and turning some implementations
> which use these into wrappers between public 32-bit and internal
> 64-bit time.
You're missing the information about what platforms this patch was tested
on with the full glibc testsuite. That's critical information for such a
patch submission, which needs testing on both 32-bit and 64-bit platforms.
(Later patches supporting using new syscalls will need testing on
additional configurations, including building with old kernel headers;
building with kernel headers with the new syscalls but running on a kernel
without them; and building with new kernel headers and running on a kernel
with the new syscalls.)
Joseph S. Myers