This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v8 1/2] Y2038: Add 64-bit time for all architectures


On Wed, 26 Sep 2018, Albert ARIBAUD (3ADEV) wrote:

> - Adding 64-bit-time support in the glibc public API.
>   This support should be dynamic, i.e. iglibc should

s/iglibc/glibc/

> +/* Define __TIME64_T_TYPE so that it is always a 64-bit type.
> + * On 64-bit platforms and X32, there is already a 64-bit time.
> + * On 32-bit platforms except X32, we need to create one.  */

I don't think the comments on the generic header should be referencing 
specific platforms such as x32 like that.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]