This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix BZ 23606 -- Missing ENDBR32 in sysdeps/i386/start.S


On 09/12/2018 01:57 PM, H.J. Lu wrote:
On Wed, Sep 12, 2018 at 12:43 AM, Florian Weimer <fweimer@redhat.com> wrote:
On 09/07/2018 09:06 AM, Terry Guo wrote:

+       /* Clearing frame pointer is insufficient, use CFI.  */
+       cfi_undefined (eip)


Isn't this a separate fix?

Since _start now includes CFI, without "cfi_undefined (eip)",  unwinder may not
terminate at _start and one unwind test will fail.

Ah! Please include this information in the commit message or ChangeLog entry, too.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]