This is the mail archive of the
mailing list for the glibc project.
Re: [patch] Fix BZ 23606 -- Missing ENDBR32 in sysdeps/i386/start.S
On Wed, Sep 12, 2018 at 12:43 AM, Florian Weimer <email@example.com> wrote:
> On 09/07/2018 09:06 AM, Terry Guo wrote:
>> + /* Clearing frame pointer is insufficient, use CFI. */
>> + cfi_undefined (eip)
> Isn't this a separate fix?
Since _start now includes CFI, without "cfi_undefined (eip)", unwinder may not
terminate at _start and one unwind test will fail.
> The ChangeLog or the commit message should mention ENDBR32 (“Use ENTRY to
> insert ENDBR32 when building for CET” or something like that).
Please also write ChangeLog as
* sysdeps/i386/start.S (_start): ...