Re: V7 test-in-container patch

[Florian Weimer <fweimer at redhat dot com>]

On 08/15/2018 07:21 AM, DJ Delorie wrote:
> Includes changes as per https://www.sourceware.org/ml/libc-alpha/2018-08/msg00293.html

There are sill a bunch of style issues, visible in:

  git show | grep '^+.*[^ ($]('

There are also a few lines longer than 79 characters.  And two instances 
of this:

  git show | grep '\. \*/'

+#define __USE_LARGEFILE64

That should be:

#define _FILE_OFFSET_BITS 64

(Twice, at least).

+/* Equivalent of "mkdir -p".  */
+void xmkdirp (const char *, mode_t);

This should probably go into <support/xunistd.h>, not <support/support.h>.

Hurd doesn't have unshare, so you need to avoid building the container 
framework there.

The Red Hat Enterprise Linux 7 kernel doesn't seem to like this 
combination of flags, even as root:

unshare(CLONE_NEWNS|CLONE_NEWUSER|CLONE_NEWPID) = -1 EINVAL (Invalid 
argument)

Is CLONE_NEWPID really required?

My concern about the over-use of FAIL_UNSUPPORTED and the UNSUPPORTED 
test status in the container framework remains.  Sure, there are some 
things that can fail due to missing host support, but e.g. a fork file 
shouldn't lead to UNSUPPORTED, but FAIL.

Thanks,
Florian