This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Linux: Rewrite __old_getdents64 [BZ #23497]

From: Florian Weimer <fweimer at redhat dot com>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, GNU C Library <libc-alpha at sourceware dot org>
Date: Fri, 10 Aug 2018 10:19:07 +0200
Subject: Re: [PATCH] Linux: Rewrite __old_getdents64 [BZ #23497]
References: <20180809115735.038EE439942E1@oldenburg.str.redhat.com> <18eb032a-6c6b-2ce2-0b4d-eaff873b64b2@linaro.org>

On 08/09/2018 04:21 PM, Adhemerval Zanella wrote:

I think we should return EXIT_UNSUPPORTED if system does not required
a compat readdir.

I disagree. UNSUPPORTED is for tests which could be run with adifferent (more recent) CPU/kernel/linker/GCC, or some additionaldependencies such as Python and GDB. If the test has no chance ofrunning ever, we should skip. Currently, this means silent success.


Thanks,
Florian

Follow-Ups:
- Re: [PATCH] Linux: Rewrite __old_getdents64 [BZ #23497]
  - From: Adhemerval Zanella

References:
- [PATCH] Linux: Rewrite __old_getdents64 [BZ #23497]
  - From: Florian Weimer
- [PATCH] Linux: Rewrite __old_getdents64 [BZ #23497]
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]