This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] RISC-V: Don't use ps_get_thread_area in libthread_db (bug 23402)


On Fri, Aug 3, 2018 at 2:37 PM, Palmer Dabbelt <palmer@dabbelt.com> wrote:
> It looks like this got lost in the shuffle, but as far as I can tell it
> makes sense.  Is anyone opposed to this, which differs only in the comment?

>    -/* Magic for libthread_db to know how to do THREAD_SELF.  */
>    +/* Informats libthread_db that the therad pointer is register 4, which
> is used
>    + * to to know how to do THREAD_SELF.  */

The new comment could use a little editing.
informats -> inform
therad -> thread
to to -> to

DJ had a valid concern that we will need to handle 32-bit support
somehow, but that could be fixed when the 32-bit support goes in.  We
just need to make sure we don't forget to add this to the 32-bit patch
set.

Jim


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]