This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v6 1/2] Y2038: Add 64-bit time for all architectures
- From: Albert ARIBAUD <albert dot aribaud at 3adev dot fr>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 1 Aug 2018 12:24:41 +0200
- Subject: Re: [PATCH v6 1/2] Y2038: Add 64-bit time for all architectures
- References: <20180706174854.546-1-albert.aribaud@3adev.fr> <20180706174854.546-2-albert.aribaud@3adev.fr> <alpine.DEB.2.20.1807172159540.19759@digraph.polyomino.org.uk>
Hi Joseph,
On Tue, 17 Jul 2018 22:01:48 +0000, Joseph Myers
<joseph@codesourcery.com> wrote :
> On Fri, 6 Jul 2018, Albert ARIBAUD (3ADEV) wrote:
>
> > bits/timesize.h | 23 +++++++++++
> > bits/timesizes.h | 37 ++++++++++++++++++
>
> The names of these headers are much too similar, and thus too confusing.
> (I think it's bits/timesizes.h that should be renamed, as the header has
> nothing to do with defining sizes of types.)
The file defines the 64-bit time type macro, so would bits/time64.h do?
> As previously noted, I consider these changes inappropriate for during the
> freeze; early in a release cycle is a much more suitable time.
Understood.
> > diff --git a/bits/timesize.h b/bits/timesize.h
> > new file mode 100644
> > index 0000000000..0739a34df4
> > --- /dev/null
> > +++ b/bits/timesize.h
> > @@ -0,0 +1,23 @@
> > +/* Bit size of the time_t type at glibc build time, general case.
> > + Copyright (C) 2018 Free Software Foundation, Inc.
> > + This file is part of the GNU C Library.
> > + Contributed by Ulrich Drepper <drepper@redhat.com>, 2002.
>
> No "Contributed by" in new files.
Overlooked when copy-pasting an existing header, fixed.
Cordialement,
Albert ARIBAUD
3ADEV