This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v8 6/8] nptl: Add abilist symbols for C11 threads

On 13/07/2018 06:50, Florian Weimer wrote:
> On 02/02/2018 06:04 PM, Adhemerval Zanella wrote:
>> This patch adds the required abilist symbols for C11 thread support.
> I manually compared the definitions in the <threads.h> header with the C11 standard.  The ABI looks good, with the exception of the once_flag definition and the possible change of the error encoding.
> Thanks,
> Florian

Thanks for all the reviews, I have updated my personal branch [1] with
all you required changes:

  - ABI fixes for mips-gnu-linux-soft.
  - pthread_create / pthread_join cast inconsistency.
  - sysdeps/nptl/threads.h moved to nptl/threads.h.
  - thrd_sleep is now a cancellable entrypoint.
  - once_flag and ONCE_FLAG_INIT and __ONCE_ALIGNMENT definition.
  - thread_local guards for C++.
  - TSS_DTOR_ITERATIONS assert check.

I am not sure about the thread error code mapping to errno, it will
required tying POSIX error code to C11 use some internal mechanism
It will most like require generate a platform-specific file 
auto-generated from errno definitions (more build complexity), and
I am not sure if this micro-optimization will really yields any
measurable gain.

If you prefer I can resend the patches on maillist with a different
version tag (I did not sent to avoid clobber the mailist).


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]