This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 6/9] RISC-V: Split the soft-fp into rv32 and rv64
On 07/12/2018 08:00 PM, Zong Li wrote:
> This is the problem I encountered, In _FP_FMA (fs, wc, dwc, R, X, Y, Z),
> it will use the _FP_FRAC_HIGHBIT_DW_##dwc macro, and it will be expanded to
> _FP_FRAC_HIGHBIT_DW_8, but the _FP_FRAC_HIGHBIT_DW_8 is not be
> implemented in soft-fp/op-8.h, there is only _FP_FRAC_HIGHBIT_DW_1,
> _FP_FRAC_HIGHBIT_DW_2 and _FP_FRAC_HIGHBIT_DW_4 in the soft-fp/op-*.h.
>
> I cannot find another 32 bit port has this issue, because they use the ldbl-128.
It appears that the code has bitrotted somewhat because of non-use.
Also, _FP_FRAC_HIGHBIT_DW_[1234] is a macro that should not exist,
because it has an identical definition in each case. But in the
meantime, just copy any of the other (identical) definitions into
op-8.h.
The other levels of macro nesting to which this expands does exist.
At least as far as I can track it by eye. ;-)
r~