This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Compile debug/stack_chk_fail_local.c with stack protector


The resulting object file is statically linked into applications, so
it is desirable to have (formal) stack protector coverage there.

2018-07-05  Florian Weimer  <fweimer@redhat.com>

	* debug/Makefile (CFLAGS-stack_chk_fail_local.c): Remove
	$(no-stack-protector).  stack_chk_fail_local.c can be compiled
	with stack protector enabled because there is no risk of infinite
	recursion.

diff --git a/debug/Makefile b/debug/Makefile
index c6f6feb0ec..d9683a8c8c 100644
--- a/debug/Makefile
+++ b/debug/Makefile
@@ -61,7 +61,6 @@ elide-routines.o := stack_chk_fail_local
 # makes no sense.
 
 CFLAGS-stack_chk_fail.c += $(no-stack-protector)
-CFLAGS-stack_chk_fail_local.c += $(no-stack-protector)
 
 CFLAGS-backtrace.c += -fno-omit-frame-pointer -funwind-tables
 CFLAGS-sprintf_chk.c += $(libio-mtsafe)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]