Re: [PATCH] testrun.sh: Implement --tool=strace, --tool=valgrind

[Szabolcs Nagy <szabolcs dot nagy at arm dot com>]

On 04/07/18 14:22, Carlos O'Donell wrote:
> On 06/30/2018 09:33 AM, Florian Weimer wrote:
> > $(file …) appears to be the only convenient way to create files
> > with newlines and make substitution variables.  This needs make 4.0
> > (released in 2013), so update the requirement to match.
> >
> > 2018-06-30  Florian Weimer  <fweimer@redhat.com>
> >
> > 	testrun.sh: Implement --tool=strace, --tool=valgrind
> > 	* Makefile (testrun-script): Define variable.
> > 	(testrun.sh): Use variable.
> > 	* manual/install.texi (Tools for Compilation): make 4.0 or later
> > 	is required.
> > 	* configure.ac: Check for make 4.0 or later.
> > 	* INSTALL: Regenerate.
> > 	* configure: Likewise.
>
> I'm OK with this. It further enhances the testsuite, and we already
> require a new enough compiler that make 4.0 should be a NOP for most
> distributions, with make 4.2.x being used by many.

this broke my testing on various targets using ubuntu
14.04 lts and older debian systems.

i will build a new make, but on other projects i prefer
to stick to 3.82. make 4.0 introduced plugin support and
other regressions so its behaviour is much less reliable.