This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] aarch64: Remove HWCAP_CPUID from HWCAP_IMPORTANT


On Friday 29 June 2018 09:43 PM, Szabolcs Nagy wrote:
> searching libraries in ".../cpuid" path or allowing cpuid
> based ifunc dispatch are quite different requirements, when
> HWCAP_CPUID is available i think those two should be possible
> to control independently (especially since searching "cpuid"
> is almost never wanted and the ifunc dispatch is almost always
> wanted).
> 
> the generic code currently only uses the mask to affect the
> library search path, the intention may be different, but my
> statement is defacto true and i don't see a good reason to
> reuse the mask for something else that may have conflicting
> requirement.

This is a different argument and I don't disagree with it.

> ok, i will wait for feedback for a while, but if you don't
> have an objection i consider this change safe.

Thanks, I also believe the change is safe, just that I am not sure if
hwcap_mask is a more popular than tune.cpu to switch off ifuncs since I
haven't been in touch with distro development for a while.  Hence my
request for more feedback.

Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]