This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: RFC V4 test-in-container
- From: Joseph Myers <joseph at codesourcery dot com>
- To: DJ Delorie <dj at redhat dot com>
- Cc: Florian Weimer <fweimer at redhat dot com>, <libc-alpha at sourceware dot org>
- Date: Fri, 29 Jun 2018 16:05:30 +0000
- Subject: Re: RFC V4 test-in-container
- References: <xnd0wagxsm.fsf@greed.delorie.com>
On Thu, 28 Jun 2018, DJ Delorie wrote:
> + # We need a working /bin/sh for some of the tests.
> + test -d $(objpfx)testroot.pristine/bin || \
> + mkdir $(objpfx)testroot.pristine/bin
> + $(test-wrapper) cp /bin/sh $(objpfx)testroot.pristine/bin/sh
> + # Copy these DSOs first so we can overwrite them with our own.
> + for dso in `$(test-wrapper-env) LD_TRACE_LOADED_OBJECTS=1 $(objpfx)elf/$(rtld-installed-name) \
> + $(objpfx)testroot.pristine/bin/sh \
I remain concerned about copying /bin/sh rather than having a local
sh-substitute. Can using the newly built dynamic linker to trace what's
required by /bin/sh really work even in as simple a case as testing i386
glibc on an x86_64 system, where /bin/sh is a 64-bit binary?
--
Joseph S. Myers
joseph@codesourcery.com