This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] posix: Sync gnulib regex implementation
On 29/06/2018 12:41, Florian Weimer wrote:
> On 06/29/2018 05:26 PM, Paul Eggert wrote:
>> As I recall the last time I suggested adding it, the only concern raised was over the licensing boilerplate at the start of the file. I have fixed that in Gnulib, so as far as I know the concerns have been addressed. We can make intprops.h's addition independent by separating its addition into a separate patch, as I proposed in my most-recent email.
>
> Most of intprops.h is untestable due to lack of relevant implementations existing out there on which the code could be tested, so I think it's not maintainable and does not match current glibc quality standards.
>
> Florian
I tried to check the pos-processed implementation using intprops.h for
the snippet:
---
bool wrap_int (int a, int b, int *r)
{
return INT_ADD_WRAPV (a, b, r);
}
---
And its results are pretty much unreadable [1]. I think I tend to agree
with Florian where a simple implementation should be better than import
all intprops.h.
Paul, could you check what I am missing on the overflow check so we can
move forward? I really don't want to get this sync stalled because of
intprops.h addition as a pre-requisite.
[1] https://paste.ubuntu.com/p/QCr3QQ6X5w/