This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v4] Fix Linux fcntl OFD locks for non-LFS architectures (BZ#20251)

On Tue, 26 Jun 2018, Adhemerval Zanella wrote:

> I will push it shortly.

The pushed commit includes a dubious change to 
sysdeps/mach/hurd/bits/errno.h.

Maybe parts of that change are correct in that they are in fact the 
results of regenerating that file, but if regenerating that file involves 
inserting a line saying 
"/home/azanella/Projects/glibc/build/i686-gnu/errnos.d", there is clearly 
a bug in the generation process; generated checked-in files should never 
depend on individual build paths like that.

-- 
Joseph S. Myers
joseph@codesourcery.com
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]